Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trailing slash to monitoring url #1538

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

soujay
Copy link
Contributor

@soujay soujay commented Jun 25, 2023

@soujay soujay requested a review from WilliamBZA June 25, 2023 20:22
@soujay soujay self-assigned this Jun 25, 2023
@WilliamBZA
Copy link
Member

@soujay
Copy link
Contributor Author

soujay commented Jun 28, 2023

Should we remove https://github.com/Particular/ServicePulse/blob/master/src/ServicePulse.Host/vue/src/composables/serviceServiceControlUrls.js#L108 as part of this PR?

@WilliamBZA - No, Looks like that function is called while updating the urls . So if there is no value in the monitoring url text box and the save button is clicked it considers monitoring to be disabled and adds in a "!" and the "Test" button is disabled.

@WilliamBZA
Copy link
Member

if there is no value in the monitoring url text box and the save button is clicked it considers monitoring to be disabled and adds in a "!" and the "Test" button is disabled.

Why wouldn't that be correct behaviour?

@soujay soujay merged commit 669582a into master Jun 30, 2023
5 checks passed
@soujay soujay deleted the add-trailing-slash-conn-url branch June 30, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection test fails if the URL does not end with a slash
2 participants