Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify a Windows client edition #114

Merged
merged 2 commits into from
Aug 23, 2017
Merged

specify a Windows client edition #114

merged 2 commits into from
Aug 23, 2017

Conversation

adamralph
Copy link
Member

Fixes #110

@adamralph adamralph self-assigned this Aug 22, 2017
@adamralph adamralph requested a review from a team August 22, 2017 15:07
README.md Outdated
@@ -21,7 +21,9 @@ The [`asp-net-mvc` solution](demos/asp-net-mvc) demonstrates the use of ASP.NET

### Install the pre-requisites

To complete the exercises, you require a Windows machine and Visual Studio. Please ensure you have followed these steps:
To complete the exercises, you require a Windows machine and Visual Studio. You must be using a Windows client edition, such as Windows 10, rather than a server edition, such as Windows Server 2016. The Particular Platfom Installer does not work on server editions of Windows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say is not supported on server editions instead doesn't not work? that in my mind sounds like a bug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will edit.

@adamralph
Copy link
Member Author

@mauroservienti what do you think of the new wording?

"does not support" as in "Windows Server 2016 is not a supported platform".

@mauroservienti
Copy link
Member

Like it!

@adamralph adamralph merged commit 6b11702 into master Aug 23, 2017
@adamralph adamralph deleted the windows-client-edition branch August 23, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants