Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update routing_content_core_6.partial.md #4124

Merged
merged 9 commits into from Oct 22, 2019
Merged

Update routing_content_core_6.partial.md #4124

merged 9 commits into from Oct 22, 2019

Conversation

seanfarmar
Copy link
Contributor

No description provided.

@seanfarmar
Copy link
Contributor Author

I've removed it from routing_content_core_[,6).partial.md and moved the note into the
Instance mapping file section.

And changed the wording... Hope this is better...

What do you think?

@seanfarmar
Copy link
Contributor Author

Updated

@mauroservienti
Copy link
Member

What’s missing here to get this in?

@mauroservienti
Copy link
Member

@seanfarmar ping

@seanfarmar
Copy link
Contributor Author

@mauroservienti I think it's all done if we have reviewers happy?

timbussmann
timbussmann approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@timbussmann timbussmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, however I don't know whether the note will be rendered correctly using the bullet points here. We definitely have to verify this once merged. Maybe check with the #doco channel first?

@mauroservienti mauroservienti merged commit bf94232 into master Oct 22, 2019
@mauroservienti mauroservienti deleted the instance-mapping-error-audit-effects branch October 22, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBoike DavidBoike DavidBoike left review comments

@mauroservienti mauroservienti mauroservienti left review comments

@timbussmann timbussmann timbussmann approved these changes

@andreasohlund andreasohlund Awaiting requested review from andreasohlund

@SzymonPobiega SzymonPobiega Awaiting requested review from SzymonPobiega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seanfarmar @mauroservienti @andreasohlund @SzymonPobiega @DavidBoike @timbussmann