Add note about duplicate entries in subscription queue #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauroservienti
requested changes
Mar 6, 2019
persistence/msmq/subscription.md
Outdated
| @@ -7,7 +7,9 @@ related: | |||
| - samples/msmq/persistence | |||
| --- | |||
|
|
|||
| Note: The subscription queue can contain duplicate entries and is by design. This does not result in events to be published multiple times. After a publisher restarts the subscription queue state will be rewritten and deduplicated. | |||
There was a problem hiding this comment.
Suggested change
| Note: The subscription queue can contain duplicate entries and is by design. This does not result in events to be published multiple times. After a publisher restarts the subscription queue state will be rewritten and deduplicated. | |
| Note: The subscription queue can contain duplicate entries and is by design. This does not result in events to be published multiple times as publishers deduplicates at publishing time. Each time a publisher is restarted the subscription queue state will be rewritten and deduplicated. |
There was a problem hiding this comment.
@mauroservienti it is incorrect, it doesn't dedupe during publishing, it dedupes during reading the subscriptions and when receiving a subscription request from a subscriber. Let me see if I can rewrite.
dvdstelt
approved these changes
Mar 6, 2019
mauroservienti
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on forum post https://discuss.particular.net/t/msmq-persistence/1014/21