Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More resilient ASBS lock renewal sample. #5677

Merged
merged 6 commits into from May 16, 2022
Merged

More resilient ASBS lock renewal sample. #5677

merged 6 commits into from May 16, 2022

Conversation

ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Mar 17, 2022 •
edited

  • Renews more often
  • Feature passed configured queue
  • Checks lock duration before starting processing for potential issues caused by prefetching
  • Will try renewing is a lock renewal attempt fails until the lock actually is expired

@ramonsmits ramonsmits self-assigned this Mar 17, 2022
danielmarbach
danielmarbach reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@danielmarbach danielmarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely aligned with the severity of some of these logs but that is arguably a matter of taste so I won't comment further.

samples/azure-service-bus-netstandard/lock-renewal/ASBS_2/LockRenewal/LockRenewalBehavior.cs Show resolved Hide resolved
@stale stale bot added the stale Pull request has had no activity for 30 days. label May 1, 2022
@ramonsmits ramonsmits removed the stale Pull request has had no activity for 30 days. label May 2, 2022
@Particular Particular deleted a comment from stale bot May 2, 2022
@ramonsmits ramonsmits force-pushed the asb-lock-renewal-improvements branch from f56d9b4 to 42f4649 Compare May 16, 2022 12:27
@ramonsmits ramonsmits merged commit 966ddf6 into Particular:master May 16, 2022
@ramonsmits ramonsmits deleted the asb-lock-renewal-improvements branch May 16, 2022 14:42
HEskandari pushed a commit that referenced this pull request Jun 3, 2022
@ramonsmits @HEskandari
More resilient ASBS lock renewal sample. (#5677)
4a695d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbussmann timbussmann timbussmann left review comments

@danielmarbach danielmarbach danielmarbach approved these changes

Assignees

@ramonsmits ramonsmits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramonsmits @danielmarbach @timbussmann