Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in SetBuildVersion because it is adding +[number] #202

Closed
GeertvanHorrik opened this issue Jul 2, 2014 · 2 comments
Closed

Comments

@GeertvanHorrik
Copy link
Contributor

Found in discussion: #201

Question: what does "0.2.0-unstable.10+10" mean?

It's the result of SetBuildVersion call. When I debug with this url:

/url https://github.com/Orcomp/C5Intervals /b develop /output buildserver

Caused by a call to semanticVersion.ToString("f")

According to @JakeGinnivan , it might be a bug.

@GeertvanHorrik
Copy link
Contributor Author

It looks like explicitly coded:

            case "f":
                {
                    var buildMetadata = BuildMetaData.ToString();

                    return !string.IsNullOrEmpty(buildMetadata) ? string.Format("{0}+{1}", ToString("s"), buildMetadata) : ToString("s");
                }

I am not sure how this code was intended.

@JakeGinnivan
Copy link
Contributor

This is by design looking into it. Closing this, can reopen another issue down the track if need be to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants