Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release tag sorting is incorrect #294

Closed
dtabuenc opened this issue Nov 11, 2014 · 4 comments · Fixed by #295
Closed

Pre-release tag sorting is incorrect #294

dtabuenc opened this issue Nov 11, 2014 · 4 comments · Fixed by #295
Assignees
Milestone

Comments

@dtabuenc
Copy link
Contributor

Current comparison compares between to strings that are not directly equivalent:

var nameComparison = StringComparer.InvariantCultureIgnoreCase.Compare(Name, other);

This causes incorrect sorting of versions with pre-release tagas (e.g. 1.0.0.rc.3 might come before 1.0.0.rc.1)

@dtabuenc
Copy link
Contributor Author

Including Pull Request for fix

#295

@gep13 gep13 reopened this Nov 12, 2014
@gep13
Copy link
Member

gep13 commented Nov 12, 2014

Although merged, this has not been deployed yet

@gep13 gep13 self-assigned this Nov 12, 2014
@gep13 gep13 added this to the 1.3.4 milestone Nov 12, 2014
@JakeGinnivan
Copy link
Contributor

I am closing issues which have not been released. You can see undeployed fixes by looking at current milestone

@gep13
Copy link
Member

gep13 commented Nov 17, 2014

@JakeGinnivan okay dokay. In which case, the deployed column in ZenHub board can be removed, as it will never contain anything.

@SimonCropp SimonCropp added the bug label Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants