Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update InitialETHCrowdfund #351

Merged
merged 7 commits into from
Dec 4, 2023
Merged

fix: update InitialETHCrowdfund #351

merged 7 commits into from
Dec 4, 2023

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Nov 29, 2023 •
edited
Loading

@height Height
Copy link

height bot commented Nov 29, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@0xble 0xble requested a review from arr00 November 29, 2023 17:44
arr00
arr00 reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments from a first pass. I'm not sure that the additional changes beyond the addressed findings are beneficial.

contracts/crowdfund/ETHCrowdfundBase.sol Outdated Show resolved Hide resolved
contracts/crowdfund/ETHCrowdfundBase.sol Outdated Show resolved Hide resolved
contracts/crowdfund/ETHCrowdfundBase.sol Outdated Show resolved Hide resolved
contracts/renderers/CrowdfundNFTRenderer.sol Outdated Show resolved Hide resolved
@0xble 0xble requested a review from arr00 December 4, 2023 19:35
arr00
arr00 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xble 0xble merged commit eef9ffe into c4-mitigations Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arr00 arr00 arr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xble @arr00