Update sdlgamecontroller.inc to 2.0.22 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Impressive update! Thank you! Just a minor thing: Could you lower-case the U in line 456+457 and 482+483 for consistency, hence |
|
I'm not a fan of all-lowercase identifiers, but I guess that's something we can add to the "style guide" discussion. I'll add a commit to change those. |
|
I consider merging this PR soon if you don't mind, as it is too important to be delayed too long and the minor issue is of cosmetic nature only. This can still be fixed in the future. |
|
Merged - thanks again, great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
sdlgamecontroller.incto matchSDL_gamecontroller.has of SDL 2.0.22.