Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -c and --config functionality #19

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

Namatuzio
Copy link
Contributor

Added a helpful description to give the user information on the -c or --config argument.

Added a helpful description to give the user information on the -c or --config argument.
@Namatuzio
Copy link
Contributor Author

Hey @Pasqua101 I was wondering how you wanted me to handle stylesheets with the toml config files.

Normally, stylesheets don't have a default argument, so I was wondering if you wanted me to add one, or simply throw an error when a stylesheet isn't given in a toml file.

This is the example of the default stylesheet arg:
image
If this is implemented, I'll also update the default to keep code/functionality consistent.

annnnnnd here is the exception handled stylesheet
image

Not too sure how you would want this handled but either way is a pretty quick fix, thanks again.

@Pasqua101
Copy link
Owner

Hey, thanks for the comment and showing the two ideas. I never really thought about having a default stylesheet (but I probably could've used one). But I like the idea of providing a default stylesheet instead of throwing an error. I'm thinking of the default stylesheet sort of being like a convenience to the user to have. Since they may not have to worry about making or finding one. Thanks again for pointing this out. Please go ahead and make the change to include a default stylesheet.

@Namatuzio
Copy link
Contributor Author

Sounds good, I'll get to committing my changes, thanks boss.

Updated the README and added the -c and --config functionality to allow multiple arguments to be ran with one TOML file.
@Namatuzio
Copy link
Contributor Author

Alright, everything is pushed and ready to be reviewed.

Closes #18
In this PR I have:

  • Added TOML functionality with -c and --config
  • Added helpful information to the -h argument
  • Added a test config.toml file
  • Updated the README to reflect all changes that have been made

Let me know if you want any updates or changes to be made I will gladly fix them up.

@Namatuzio Namatuzio marked this pull request as ready for review October 5, 2023 02:41
@Namatuzio Namatuzio changed the title Added -h information Added -c and --config functionality Oct 5, 2023
@Pasqua101 Pasqua101 merged commit bf895f6 into Pasqua101:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants