Add checks for catching errors while importing project settings. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ThunderKit for setting up unity to mod Kerbal Space Program 2, we consistently run into an out of memory error while trying to import project settings, something necessary for us to do things like rendering drag cubes for the game. After doing some investigating, I found that ignoring the assets in the game managers file that cause this error (via a try catch) and logging them fixed these issues for us, as such this PR adds that to the ImportProjectSettings file, and adds an option into the ThunderKit settings that enables or disables logging any errors found while importing the project settings.