Skip to content

Commit

Permalink
Merge bitcoin#22204: doc: remove obsolete okSafeMode RPC guideline …
Browse files Browse the repository at this point in the history
…from developer notes

6780a09 doc: remove obsolete `okSafeMode` RPC guideline from developer notes (Sebastian Falbesoner)

Pull request description:

  Since the flag has been removed from the RPC command table in commit ec6902d (PR bitcoin#11179), this guideline is not relevant anymore and can be removed.

ACKs for top commit:
  MarcoFalke:
    ACK 6780a09. Also, safe mode was removed completely in commit 2ae705d

Tree-SHA512: 2a6b002ae302e979ce403171b79a892e32f5083792c3b0b8204edb5eb08c6b24ab77bbeeae0e3bb6d6564a6f1678cfce00eb7b5b82063b7741f89a96b0c0aef3
  • Loading branch information
MarcoFalke authored and PastaPastaPasta committed Jul 16, 2021
1 parent cfd9a89 commit 289c877
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions doc/developer-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -908,13 +908,6 @@ A few guidelines for introducing and reviewing new RPC interfaces:

- *Rationale*: If not, the call can not be used with name-based arguments.

- Set okSafeMode in the RPC command table to a sensible value: safe mode is when the
blockchain is regarded to be in a confused state, and the client deems it unsafe to
do anything irreversible such as send. Anything that just queries should be permitted.

- *Rationale*: Troubleshooting a node in safe mode is difficult if half the
RPCs don't work.

- Add every non-string RPC argument `(method, idx, name)` to the table `vRPCConvertParams` in `rpc/client.cpp`.

- *Rationale*: `dash-cli` and the GUI debug console use this table to determine how to
Expand Down

0 comments on commit 289c877

Please sign in to comment.