Skip to content

Commit

Permalink
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
Browse files Browse the repository at this point in the history
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
  • Loading branch information
laanwj authored and PastaPastaPasta committed Jul 10, 2021
1 parent 4a543ac commit 368f5f0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
Expand Up @@ -212,7 +212,10 @@ consensus to merge a pull request (remember that discussions may have been
spread out over GitHub, mailing list and IRC discussions). The following
language is used within pull-request comments:

- ACK means "I have tested the code and I agree it should be merged";
- (t)ACK means "I have tested the code and I agree it should be merged", involving
change-specific manual testing in addition to running the unit and functional
tests, and in case it is not obvious how the manual testing was done, it should
be described;
- NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification (or in certain cases of copyright/patent/licensing
issues, legal justification). NACKs without accompanying reasoning may be
Expand Down

0 comments on commit 368f5f0

Please sign in to comment.