Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge bitcoin#16095: Catch by reference not value in wallettool
ae7faf2 Exceptions should be caught by reference, not by value. (Kristaps Kaupe) Pull request description: Fixes this warning with GCC8/GCC9: ``` wallet/wallettool.cpp: In function ‘std::shared_ptr<CWallet> WalletTool::LoadWallet(const string&, const boost::filesystem::path&)’: wallet/wallettool.cpp:62:25: warning: catching polymorphic type ‘const class std::runtime_error’ by value [-Wcatch-value=] } catch (const std::runtime_error) { ^~~~~~~~~~~~~ ``` Related to bitcoin#15822. ACKs for commit ae7faf: practicalswift: utACK ae7faf2 Tree-SHA512: 07eb774b3296c0b66ac5040269bff6cd8ba0294c8c95cc08c595efbd535260ff0010fa430ca057eeccd7b38c0a981a3d7a95b675d9e2996853c013dc0bfe8127
- Loading branch information