Skip to content

Commit

Permalink
Remove reference to nonexistent "version" wallet transaction mapvalue…
Browse files Browse the repository at this point in the history
… field

This change removes a mapValue.erase("version") statement which deletes a
mapValue entry that never existed. The statement was mistakenly added in commit
865c3a2 in 2010 and is harmless but confusing.
  • Loading branch information
ryanofsky committed Dec 14, 2016
1 parent 654e044 commit a1fe944
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/wallet/wallet.h
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,6 @@ class CWalletTx : public CMerkleTx
* "timesmart" - serialized nTimeSmart value
* "spent" - serialized vfSpent value that existed prior to
* 2014 (removed in commit 93a18a3)
*
* A mapValue.erase("version") statement also appears in the code,
* originating from commit 865c3a2 in 2010, but it does not appear that any
* "version" entries were actually ever created by any version of bitcoin.
*/
mapValue_t mapValue;
std::vector<std::pair<std::string, std::string> > vOrderForm;
Expand Down Expand Up @@ -381,7 +377,6 @@ class CWalletTx : public CMerkleTx
}

mapValue.erase("fromaccount");
mapValue.erase("version");
mapValue.erase("spent");
mapValue.erase("n");
mapValue.erase("timesmart");
Expand Down

0 comments on commit a1fe944

Please sign in to comment.