This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Dispatch from ForgeHooks to WorldEvents #133
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add onDifficultyChange as well, not as certain about that one being in the right place.
This was referenced Jul 17, 2020
kitlith
requested review from
TwilightFlower
and removed request for
TwilightFlower
|
I'm going to say this blocks on #126 for now, I will either rebase on top of that tomorrow or wait for it to be merged. |
|
hi yes please revisit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally in #121, I broke out onBlockBreakEvent to WorldEvents as well. However, this is also being performed in #126, so for the moment I'm going to leave that to #126 unless otherwise requested.
I'm also not really certain where
onDifficultyChangeshould go. I placed it in the world module in #121, but now i'm not so sure.