Log errors from callback form #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnschoeman
approved these changes
Sep 16, 2020
src/Callback/Form.tsx
Outdated
| }) | ||
| Logger.error( | ||
| `FailureToRequestCallback.${response.error}.${ | ||
| response.message || defaultErrorMessage |
There was a problem hiding this comment.
defaultErrorMessage is assigned to" " here, should we be using something different for the logger?
Why: ---- Once we have the call back form online we will need some visibility on the behavior of the same while we are testing on staging. This Commit: ---- - Add logging logic to the call back form - Add tests for the error handling on the component
aledustet
force-pushed
the
chore/callback-request-error-handling
branch
from
035b261
to
b8283ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Once we have the call back form online we will need some visibility on the behavior of the same while we are testing on staging.
This Commit: