Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place symptoms on a union type #456

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

aledustet
Copy link
Contributor

Why:

We need to ensure type safety with the data on the UI side, in case a
new symptom is added or removed.

This Commit:

  • Create symptoms union type
  • Move translations to select symptoms form

Co-authored-by: John Schoemanjohnschoeman1617@gmail.com

Why:
----

We need to ensure type safety with the data on the UI side, in case a
new symptom is added or removed.

This Commit:
----

- Create symptoms union type
- Move translations to select symptoms form

Co-authored-by: John Schoeman<johnschoeman1617@gmail.com>
Copy link
Contributor

@johnschoeman johnschoeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@devinjameson devinjameson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@aledustet aledustet merged commit f2d54ed into develop Sep 28, 2020
@aledustet aledustet deleted the chore/type-symptom-values branch September 28, 2020 12:11
tokumori pushed a commit to AlohaSafe/gaen-mobile that referenced this pull request Oct 1, 2020
Why:
----

We need to ensure type safety with the data on the UI side, in case a
new symptom is added or removed.

This Commit:
----

- Create symptoms union type
- Move translations to select symptoms form

Co-authored-by: John Schoeman<johnschoeman1617@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants