Handle location services disabled when requesting ENs #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjameson
commented
Dec 2, 2020
johnschoeman
approved these changes
Dec 2, 2020
mattThousand
previously requested changes
Dec 2, 2020
devinjameson
commented
Dec 8, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
wontfix
* Adjust iOS scoring threshold. (#727) #### Why: We'd like the scoring threshold check to reflect the original intention and be consistent across platforms. #### This commit: This commit brings the scoring threshold check for devices running `iOS 13.7+` in line with the Android implementation; the android implementation appropriately converts the the `weightedDurationSum` to minutes before making the comparison (https://github.com/Path-Check/gaen-mobile/blob/79e4d0091417fb71533edd3195d049b243be1fcd/android/app/src/main/java/org/pathcheck/covidsafepaths/exposurenotifications/ExposureNotificationClientWrapper.java#L229), and this commit performs the identical check in reverse, converting the `triggerThresholdWeightedDuration` value to seconds to perform the check * Upgrade WorkManager to fix a crash (#726) * Return bluetooth and location status when EN status is requested Co-authored-by: Matt Buckley <matt.buckley@rocketinsights.com>
…fications (iOS) #732 Why: When requesting to enable exposure notifications from the JS layer, we'd like to treat responses other than an Active status as errors. This commit: This commit updates the iOS exposure enablement call to vend a success to the JS layer only if the exposureNotificationStatus is Active after the request, and vends and error otherwise
* Adjust iOS scoring threshold. (#727) #### Why: We'd like the scoring threshold check to reflect the original intention and be consistent across platforms. #### This commit: This commit brings the scoring threshold check for devices running `iOS 13.7+` in line with the Android implementation; the android implementation appropriately converts the the `weightedDurationSum` to minutes before making the comparison (https://github.com/Path-Check/gaen-mobile/blob/79e4d0091417fb71533edd3195d049b243be1fcd/android/app/src/main/java/org/pathcheck/covidsafepaths/exposurenotifications/ExposureNotificationClientWrapper.java#L229), and this commit performs the identical check in reverse, converting the `triggerThresholdWeightedDuration` value to seconds to perform the check * Upgrade WorkManager to fix a crash (#726) * Return bluetooth and location status when EN status is requested Co-authored-by: Matt Buckley <matt.buckley@rocketinsights.com>
…fications (iOS) #732 Why: When requesting to enable exposure notifications from the JS layer, we'd like to treat responses other than an Active status as errors. This commit: This commit updates the iOS exposure enablement call to vend a success to the JS layer only if the exposureNotificationStatus is Active after the request, and vends and error otherwise
devinjameson
force-pushed
the
dj-fix-location
branch
from
9f78048
to
c7517b6
Compare
added 2 commits
December 15, 2020 13:53
tokumori
pushed a commit
to AlohaSafe/gaen-mobile
that referenced
this pull request
Dec 31, 2020
Why: some Android devices require location services to be enabled for exposure notifications to work. If someone is on such a device and tries to enable exposure notifications with location services disabled, would like to show an alert that tells them to enable location services. This commit: Adds LocationOffAndRequired to the list of possible states for the ENPermissionStatus If ENPermissionStatus is LocationOffAndRequired, show an alert to the user telling them to enable location services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: some Android devices require location services to be enabled for exposure notifications to work. If someone is on such a device and tries to enable exposure notifications with location services disabled, would like to show an alert that tells them to enable location services.
This commit:
LocationOffAndRequiredto the list of possible states for theENPermissionStatusENPermissionStatusisLocationOffAndRequired, show an alert to the user telling them to enable location services