Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/Add-external-links #947

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Improvement/Add-external-links #947

merged 3 commits into from
Dec 7, 2021

Conversation

mxMarkowitz
Copy link
Contributor

Why:

Start restructure to improve testability, reusability, and improve code consistency
Add links to external links on main page

This commit:

Starts an organization to bring better testability to the system

  • Moves Components into a folder structure that allows tests to be isolated
  • Breaks up ConfigurationContext into multiple files so tests can be written against it
  • Renames CheckBox to CheckBox for consistency
  • Change to using named exports, default exports have pitfalls and almost no benefits

Add new values to allow external links to custom links

  • add externalLink component
  • set env variables to allow custom links

How to test:

Add new values to env.bt file:
EXTERNAL_COVID_DATA_LINK=
EXTERNAL_COVID_DATA_LABEL=
EXTERNAL_TRAVEL_GUIDENCE_LINK=

Copy link
Contributor

@si1k si1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. tyvm.

@si1k si1k merged commit dfc6472 into develop Dec 7, 2021
@si1k si1k deleted the external-la-links branch December 7, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants