Issue 564 - change message ( fixed english only ) #574
Conversation
There was a problem hiding this comment.
Thanks for this PR. Summary of thoughts from out of band discussion with @tstirrat on this. This is definitely an improvement, but would like the messages to be a bit more clear and user centric. Right now, I can think of 3 cases:
- the user stopped the location service via the phone's settings. We should tell them the consequence of this change (that we cannot determine your exposure history). They know what they just did, so really we want them to know the consequence - and the current message really doesn't do that.
- the user stopped the location service in the app. Again, we should tell them the consequence of this change. I would think this would be the same message as case 1
- the location service stopped for a reason that wasn't a user action. Honestly I'm not sure if this can be detected or not (or even happen), but if so, then I think the message is a slightly different message.
Also ... as I was thinking about it, these messages can show up later when the app is restarted or comes back to the foreground. The current messages do not really help the user to know how to fix the issue. It would be helpful if you can get this case covered as well.
|
Can you add more verbose message keys and preferable title also? Given that the PR is dedicated towards only changing the message which is same for the both case right now, I would suggest only change text and get it in, and make a ticket for much in depth UI/UX for the events of location being disabled/enabled etc. |
|
Makes sense. Leave it with me! |
|
Actually One clarification @tremblerz , the proposed change will distinguish between if the location services have been switched off externally or if its the user clicking the stop tracking icon. So what you are suggesting is to change the message when location services have been disabled externally I cant help thinking that the title and message duplicate information, as they are both displayed together at all times. the message can show more info as the font is smaller. How does that sound? |
On that note, you also don't need 'has been' in these two strings. The meaning is still conveyed and is shorter and might look better on screen. "location_disabled_title": "Device location disabled.", |
|
agreed |
Signed-off-by: Patrick Erichsen <patrick.a.erichsen@gmail.com>
### Testing Notes ### as before ### Fixed Issues ### Resolves Path-Check#564
|
I did a test on this (Pixel 2 emulator), and it gets stuck showing "stopped at user request" even though I actually have location permissions disabled in the OS. I would expect it to say "Location access to Safe Paths removed. Please enable it in the settings for effective logging." right? I suspect we need more thorough checks.. Can you show a video of how it should be working? |
tstirrat
dismissed
their stale review
Functional test did not match what I expected
tstirrat
added
Do Not Merge (yet)
|
Thanks for helping me on this @tstirrat . |
…ge. Also changed the enabled message to follow the same pattern.
|
just confirmed that this defect exists without my changes. in fact when location services disabled it gets a bit messed up. the app can think location tracking is enabled when its not as well as getting stuck at Location tracking disabled ( which is the original message before my changes ) Ill raise an issue for this. |
|
issue #685 raised |
* enable haitian creole tests * get the tests running with onboarding 5 changes * revert accidental commit for config * remove check for notification as it's not supported * upload screenshots on failure * let's save some failed screenshots * try disabling builds if the only code pushed is for e2e * disable the check for content on the home screen as it's not always returning the same thing * comment out the paths filter because of our requirements for PR merge * remove the paths filter because of our requirements for PR merge
### Testing Notes ### as before ### Fixed Issues ### Resolves Path-Check#564
…ge. Also changed the enabled message to follow the same pattern.
|
apologies for the delay in updating. I have shortened the messages so they fit into the android notification message area. I have also significantly changed the word 'securely' to 'anonymously' in the Enabled message. I think it is more accurate and better for PR (it seems all the press is talking about how contact tracing is bad for your privacy rights) so I thought this would be a better message and would make our app rise above... regarding the issues you saw @tstirrat i have a separate PR coming to fix that issue (issue-685) |
|
Superseded by #725 |
Description
resolves issue 564. the message was confusing so was changed (in the english resourse only ) to the suggested stopped when location services are disabled or stopped at user request
How to test
1 go to settings,
click on stop logging text or icon,
see message appears. it should now read
Location Tracking was disabled
Stopped at user request.
2 go to settings
turn off location services from OS.
click on stop logging text or icon
see message appears. it should now read
Location Tracking was disabled
Stopped.
(any ideas for unit tests)
Still todo other languages (please advise!)
(In another locale the english text will appear until the translation is present I think)
Fixes #564