-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FamPlex #131
Closed
Closed
Support FamPlex #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for FamPlex namespaced entities (family and complex) including 31 tests for FamPlex entities. I corrected some older test cases that, in fact, references families (e.g.
Acc
,p70S6K
).There are some additional changes and dependencies that should be addressed at some point (see Outstanding and Related issues)
Entity "type"?
The
ENTRY_TYPE
for famplex is currently set to 'entity'.There are several alternatives to consider:
entity
entity
doesn't appear to be an option; update requiredbp:PhysicalEntity
but no external grounding is attached.ggp
complex
complex/family
entity
anywaysTest results
Added
famplex.json
Test cases added for each of the top 15 most frequently referenced entities:
Results
I summarize the search accuracy, without and with FamPlex ( texts, data ):
Below, I report additional failing cases when Famplex data and tests are included:
**rank indicates the rank order in search results; -1 means it was not returned at all
Refs #130