Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Modifier API: Capture from canvas directly without AndroidView #100

Closed
PatilShreyas opened this issue Jun 9, 2023 Discussed in #98 · 5 comments · Fixed by #137
Closed

New Modifier API: Capture from canvas directly without AndroidView #100

PatilShreyas opened this issue Jun 9, 2023 Discussed in #98 · 5 comments · Fixed by #137
Labels
enhancement New feature or request

Comments

@PatilShreyas
Copy link
Owner

Discussed in #98

@yschimke
Copy link

https://twitter.com/riggaroo/status/1693961082761625825?t=kfgghffcZXsuhus0txy90w&s=19

Think you saw this already

@PatilShreyas PatilShreyas added the enhancement New feature or request label Oct 2, 2023
@PatilShreyas PatilShreyas changed the title Capture from canvas directly without AndroidView New Modifier API: Capture from canvas directly without AndroidView Oct 2, 2023
PatilShreyas added a commit that referenced this issue Oct 2, 2023
PatilShreyas added a commit that referenced this issue Oct 2, 2023
PatilShreyas added a commit that referenced this issue Oct 2, 2023
@jsericksk
Copy link

I tested the code you put in the #103 and the problem with capturing scrollable content continues, even though you mentioned that the new API solved this problem. Is it really working for you? Is there anything else that needs to be done to make Column(Modifier.verticalScroll()) work? It also doesn't work with documentation snippet.

@PatilShreyas
Copy link
Owner Author

@jsericksk Yes, when I tested, it worked nicely. Can you share me a snippet or a sample?

@jsericksk
Copy link

Sorry, @PatilShreyas. I realized that when I was testing, I was applying Modifier.capturable() to the parent component and not to the capturable component directly, so I was only capturing the currently visible part. It's working normally now. Looking forward to the next release!

@PatilShreyas PatilShreyas linked a pull request Jan 25, 2024 that will close this issue
@PatilShreyas
Copy link
Owner Author

This issue has been fixed and released in version 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants