-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch in catches of comparables #13
Comments
I include a small video that I have made from the app so you can see how the Capturable area looks like, the Capturable area would be the following: Capture generated when the compostable is fully displayed on the screen |
Any news or solutions to this problem @PatilShreyas? 🤔 |
Thanks for the image and videos @jeluchu. Will look into it |
Fix #13: Revisit capturing logic
This issue has been fixed and released in |
@PatilShreyas I have updated the library to version 1.0.3, but the error that I indicated in this incident still occurs, as soon as the content is no longer in view the generated image is not correct or expected, here you can see the test I have done https://ibb.co/svtkDJ9, it is hiding because there is a Toolbar above, as below is the button that calls the function to generate the biome, if not down in the view is complete: https://ibb.co/WcTKXD1 but to generate the bitmap is cut as you indicated in the first picture |
Are you also including toolbar inside Capturable composable's content? |
@PatilShreyas No, in principle this is inside a Scaffold, which then inside has a LazyColumn and inside is the Capturale
|
If this |
|
No, whatever network image you're using, every network image builder has an option for that. For e.g. coil also has it. Just say |
Yes, I use Coil, I have just tried what you have indicated and it seems to be working correctly, thank you very much @PatilShreyas! |
Hello again!
I've been doing some tests, and I've seen a couple of things that I don't know if this is really the case or if they are errors. I'll tell you about them so that you can clarify them for me.
I have a LazyColumn that has several items both above and below Capturable. I have in one of them a button with which I perform the
controller.capture()
action and at that moment I generate the bitmap to share/save it. The problem is that it does not really capture the composable that you have indicated, it obtains the size of the real composable, but if you have made scroll and that composable is between the TopAppBar for example the generated image is not really the one previously indicated.Capture of the image generated after the scroll has taken place
Capture generated when the compostable is fully displayed on the screen
Even if no background colour has been specified in the composable to be captured, the background colour that is inside the view is obtained, i.e. there is no option to capture the composable with a transparent background if I want it to capture it. As you can see in the images above, the background colour I have on the screen is red, but when I capture the image of the card, it adds a red background colour even though I want it to be transparent.
Thank you in advance! And thank you for your work! 😄
The text was updated successfully, but these errors were encountered: