Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instance of CaptureController in ModifierNodeElement#update #146

Closed
PatilShreyas opened this issue Feb 25, 2024 · 1 comment · Fixed by #148
Closed

Update instance of CaptureController in ModifierNodeElement#update #146

PatilShreyas opened this issue Feb 25, 2024 · 1 comment · Fixed by #148
Labels
bug Something isn't working

Comments

@PatilShreyas
Copy link
Owner

ModifierNodeElement#update is called when a modifier is applied to a Layout whose inputs have changed from the previous application. This function will have the current node instance passed in as a parameter, and it is expected that the node will be brought up to date. So if across recompositions, if an instance of CaptureController is changed then all capture requests will be lost.
@PatilShreyas PatilShreyas added the bug Something isn't working label Feb 25, 2024
PatilShreyas added a commit that referenced this issue Feb 25, 2024
@PatilShreyas
#146 | Fix: add capability for updating instance of CaptureController
8902782
This was referenced Feb 25, 2024
Merged
Merged
@PatilShreyas PatilShreyas linked a pull request Feb 25, 2024 that will close this issue
Release v2.1.0 #148
Merged
@PatilShreyas
Copy link
Owner Author

This has been fixed and released in v2.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v2.1.0 PatilShreyas/Capturable
1 participant
@PatilShreyas