Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couldn't capture composable inside Fragment: Can't get Activity instance from Fragment #22

Closed
brandlee opened this issue Mar 2, 2022 · 2 comments · Fixed by #23 or #25
Closed

Couldn't capture composable inside Fragment: Can't get Activity instance from Fragment #22

brandlee opened this issue Mar 2, 2022 · 2 comments · Fixed by #23 or #25
Labels
bug Something isn't working
Milestone
v1.0.3

Comments

@brandlee
Copy link

brandlee commented Mar 2, 2022

if I use Capturable in Fragment , an error throw: Can't get window from the Context
@PatilShreyas
Copy link
Owner

Thanks for reporting the issue @brandlee

@PatilShreyas PatilShreyas added the bug Something isn't working label Mar 10, 2022
PatilShreyas added a commit that referenced this issue Mar 17, 2022
@PatilShreyas
#22 Fix: find activity properly by traversing Context
90ac11c
@PatilShreyas PatilShreyas mentioned this issue Mar 20, 2022
Merged
5 tasks
@PatilShreyas PatilShreyas changed the title capturable in Fragment Couldn't capture composable inside Fragment: Can't get Activity instance from Fragment Mar 20, 2022
@PatilShreyas PatilShreyas added this to the v1.0.3 milestone Mar 20, 2022
@PatilShreyas PatilShreyas linked a pull request Mar 20, 2022 that will close this issue
Fix #22: Find activity properly by traversing Context #23
Merged
5 tasks
PatilShreyas added a commit that referenced this issue Mar 20, 2022
@PatilShreyas
Merge pull request #23 from PatilShreyas/fix-22/usage-in-fragment
065e623 
Fix #22: Find activity properly by traversing Context
@PatilShreyas PatilShreyas mentioned this issue Mar 20, 2022
Merged
@PatilShreyas PatilShreyas linked a pull request Mar 20, 2022 that will close this issue
Release v1.0.3 #25
Merged
@PatilShreyas
Copy link
Owner

This issue has been fixed and released in v1.0.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.3
2 participants
@brandlee @PatilShreyas