Add Share button & Gradle Kotlin DSL #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatilShreyas
requested changes
May 25, 2020
There was a problem hiding this comment.
@naufalprakoso Thanks for this PR and your contribution. Before merging it here are few comments. If you fix these then I'll be happy to merge it.
| @@ -37,6 +41,8 @@ import kotlinx.coroutines.ExperimentalCoroutinesApi | |||
| @ExperimentalCoroutinesApi | |||
| class PostDetailsActivity : BaseActivity<PostDetailsViewModel, ActivityPostDetailsBinding>() { | |||
|
|
|||
| private var getPost: Post? = null | |||
There was a problem hiding this comment.
Instead of name getPost please rename it to post Also, make it private lateinit var.
Comment on lines
94
to
104
| if (getPost != null) { | ||
| val post = getPost!! | ||
| val shareMsg = """ | ||
| "${post.title}" by ${post.author} on Foodium App | ||
| """.trimIndent() | ||
|
|
||
| val intent = Intent() | ||
| intent.action = Intent.ACTION_SEND | ||
| intent.putExtra(Intent.EXTRA_TEXT, shareMsg) | ||
| intent.type = "text/plain" | ||
| startActivity(Intent.createChooser(intent, "Share to:")) |
There was a problem hiding this comment.
You can use ShareCompat class which is recommended by Android officials for such use case. Here's the reference: https://medium.com/androiddevelopers/sharing-content-between-android-apps-2e6db9d1368b
|
Thank you for the suggestion @PatilShreyas , I already changed it. Please check my PR again 😁 |
PatilShreyas
requested changes
May 26, 2020
|
Sure, I already move it to the end of class @PatilShreyas |
|
Great! LGTM. Merging it. |
|
Thank you @PatilShreyas 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: