Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Button alignment with multi-line-text #51

Closed
jatsqi opened this issue Apr 30, 2021 · 5 comments · Fixed by #52
Closed

[BUG] Button alignment with multi-line-text #51

jatsqi opened this issue Apr 30, 2021 · 5 comments · Fixed by #52
Assignees
Milestone

Comments

@jatsqi
Copy link
Contributor

jatsqi commented Apr 30, 2021

Version: 2.2.2
API-Level: 30
Problem: If only one of the two buttons (positive, negative) has a multi-line-text, then this button is no longer aligned with the other one.
Screenshot:
See here

Is this behavior intended or is there a configuration option somewhere that I missed?
I could eventually provide a PR for this if the fix is easy. 👍

@PatilShreyas
Copy link
Owner

PatilShreyas commented May 1, 2021 via email

@jatsqi
Copy link
Contributor Author

jatsqi commented May 1, 2021

Thank you for your answer!
How do you want the layout to behave?

Option 1:
Option 1
Both buttons are pushed to the top of the container.

Option 2:
Option 2
Both buttons are centered. I think this is also consistent with the behavior in landscape mode, isn´t it?

If this question is resolved I can provide a PR for this pretty soon.

@PatilShreyas
Copy link
Owner

In my opinion, Option 2 looks good.

@PatilShreyas
Copy link
Owner

Re-opened issue since this fix is not yet released. Will close after release.

@PatilShreyas
Copy link
Owner

This has been released. Thanks for the contribution @jatsqi 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants