Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

tried to fix the problem of bounded ripple effect #11

Merged
merged 4 commits into from Feb 1, 2020

Conversation

zainfikrih
Copy link
Contributor

  • Addition of resources for the purpose of ripple effects
  • Addition of themes to eliminate the original ripple effects android:theme="@style/Widget.NavigationView.RippleEffect"
<com.shreyaspatil.material.navigationview.MaterialNavigationView
        android:id="@+id/nav_view"
        android:layout_width="wrap_content"
        android:layout_height="match_parent"
        android:layout_gravity="start"
        android:theme="@style/Widget.NavigationView.RippleEffect" 
        app:headerLayout="@layout/nav_header_main"
        app:insetForeground="@android:color/transparent"
        app:itemIconTint="@color/navigation_item_tint"
        app:itemStyle="default_style"
        app:itemTextColor="@color/navigation_item_tint"
        app:menu="@menu/activity_main_drawer" />
  • Addition of styles to change the colour of the ripple effects
    <item name="colorControlHighlight">@android:color/black</item>
<!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.MaterialComponents.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="colorPrimary">@color/colorPrimary</item>
        <item name="colorPrimaryDark">@color/colorPrimaryDark</item>
        <item name="colorAccent">@color/colorAccent</item>
        <item name="colorSecondary">@color/colorPrimary</item>
        <item name="colorControlHighlight">@android:color/black</item>
        <item name="android:fontFamily">@font/montserrat</item>
    </style>

@zainfikrih
Copy link
Contributor Author

Flag Value Description Preview
default_style This flag sets design to default style to menu item of Navigation drawer.
rounded_right This flag sets design to menu item of Navigation drawer as Rounded Corners at right
rounded_rectangle This flag sets design to menu item of Navigation drawer as Rounded Rectangular Corners

@PatilShreyas
Copy link
Owner

Thank you @zainfikrih for this PR😃.
It looks good to me.
Will review it shortly and let you know.

@PatilShreyas PatilShreyas added the enhancement New feature or request label Feb 1, 2020
@PatilShreyas
Copy link
Owner

Hi @zainfikrih I've made some modifications in your code as you can see here in this PR zainfikrih#1

Merge it into your base then I'm happy to merge it into the production and release new version soon!

@zainfikrih
Copy link
Contributor Author

Hi, I've merged PR zainfikrih/MaterialNavigationView-Android#1. Thank you

@PatilShreyas
Copy link
Owner

Thanks @zainfikrih for this PR. Now I'm merging it and releasing new version soon.

@PatilShreyas PatilShreyas merged commit 6987610 into PatilShreyas:master Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants