Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[ENHANCEMENT] Out of bound ripple on item click. #8

Closed
PatilShreyas opened this issue Oct 31, 2019 · 4 comments
Closed

[ENHANCEMENT] Out of bound ripple on item click. #8

PatilShreyas opened this issue Oct 31, 2019 · 4 comments
Assignees
@PatilShreyas
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PatilShreyas
Copy link
Owner

After the rounded item is pressed, the water ripple effect is out of bounds. Gmail is also a rounded corner style, but it won't cross the border after pressing the item.
image
image

Originally posted by @tcqq in #5 (comment)
@PatilShreyas PatilShreyas added enhancement New feature or request help wanted Extra attention is needed labels Oct 31, 2019
@PatilShreyas PatilShreyas self-assigned this Oct 31, 2019
@PatilShreyas PatilShreyas mentioned this issue Oct 31, 2019
Closed
@PremChavhan
Copy link

PatilShreyas please check #9 these pull request in which I tried to solve the problem of unbounded ripple

@zainfikrih
Copy link
Contributor

zainfikrih commented Jan 31, 2020 •
edited

@PatilShreyas Hi, please check #11
I tried to fix it. This is the development of #9

@PatilShreyas
Copy link
Owner Author

Thanks @zainfikrih for working on this.

@PatilShreyas
Copy link
Owner Author

This issue is fixed and implemented in v1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PatilShreyas PatilShreyas

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PatilShreyas @zainfikrih @PremChavhan