Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Suggestions and implementation of New item styles #5

Closed
PatilShreyas opened this issue Oct 9, 2019 · 6 comments
Closed

Suggestions and implementation of New item styles #5

PatilShreyas opened this issue Oct 9, 2019 · 6 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@PatilShreyas
Copy link
Owner

If you have good ideas or suggestions or good material design structure available for item style of MaterialNavigationView then you're at right place. You can contribute us if you have cool ideas. You are always welcome. You can open PR or simply show your design here in comments. Thank you.
@PatilShreyas PatilShreyas added enhancement New feature or request Hacktoberfest labels Oct 9, 2019
@lakhanmeghani
Copy link

Hi, I have suggestion that we could add design in which there will be radius from all sides.

@PatilShreyas
Copy link
Owner Author

@lakhanmeghani Suggestion is good. Can you send PR?

@lakhanmeghani
Copy link

Yeah Sure!

@lakhanmeghani lakhanmeghani mentioned this issue Oct 10, 2019
Closed
@tcqq
Copy link

tcqq commented Oct 24, 2019

@PatilShreyas After the rounded item is pressed, the water ripple effect is out of bounds. Gmail is also a rounded corner style, but it won't cross the border after pressing the item.
image
image

@PatilShreyas
Copy link
Owner Author

@tcqq Thanks for reporting that. I'm also looking to solve it. If you have solution on this, please open PR.

@PatilShreyas PatilShreyas mentioned this issue Oct 31, 2019
Closed
@PatilShreyas
Copy link
Owner Author

@tcqq I have opened new issue here #8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcqq @PatilShreyas @lakhanmeghani