Defect: Progress dialog keeps running in infinite loop

[Varsha-Kulkarni]

Steps to reproduce:

1. Login to the app.
2. Click on add note, navigate to add note detail screen
3. add title, add notes, click on save
4. navigate back to list of notes
5. click on newly added note, navigate to note detail screen
6. click on delete note button
7. once note deleted, it navigates back to list of notes screen where progress dialog keeps loading indefinitely

[Varsha-Kulkarni]

I would like to work on fixing this one, please assign this to me, Thanks

[PatilShreyas]

Thanks, @Varsha-Kulkarni for raising this issue.

[PatilShreyas]

This is happening in simpleapp or composeapp?

[Varsha-Kulkarni]

This is in simpleapp. Attaching a screen recording
progress_dialog_loading_infinitely.webm

[PatilShreyas]

Thanks for sharing the recording. What's the cause of this dialog's behaviour?

[Varsha-Kulkarni]

I think it is the same even when app loads the first time after logging in. It is because shouldSyncNotes always returns true because notes is empty in NotesFragment.
It tries to keep syncing indefinitely until there's data.

[PatilShreyas]

Oh yes, we need to fix it then