Fix issue 536 loading of progress indefinitely when no notes available #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [logback-classic](https://github.com/qos-ch/logback) from 1.4.1 to 1.4.3. - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.4.1...v_1.4.3) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `testContainerVersion` from 1.17.4 to 1.17.5. Updates `testcontainers` from 1.17.4 to 1.17.5 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.17.4...1.17.5) Updates `postgresql` from 1.17.4 to 1.17.5 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.17.4...1.17.5) --- updated-dependencies: - dependency-name: org.testcontainers:testcontainers dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.testcontainers:postgresql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…le/noty-api/testContainerVersion-1.17.5 [API]: Bump testContainerVersion from 1.17.4 to 1.17.5 in /noty-api
…le/noty-api/ch.qos.logback-logback-classic-1.4.3 [API]: Bump logback-classic from 1.4.1 to 1.4.3 in /noty-api
PatilShreyas
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there are no notes available, progress dialog keeps loading indefinitely trying to sync the data. The PR fixes issue #536
Description for the changelog
When the user logs into the app for the first time, app tries to sync with backend indefinitely since notes list is empty. The same is observed when all the existing notes are deleted. Notes can be synced during the first load after logging in or any error occurs while syncing. The condition which would sync notes when list is empty is removed which fixes the above issue.
Checklist