Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated OptionsMenu with MenuProvider #547

Closed
Varsha-Kulkarni opened this issue Oct 6, 2022 · 5 comments · Fixed by #558 or #559
Closed

Replace deprecated OptionsMenu with MenuProvider #547

Varsha-Kulkarni opened this issue Oct 6, 2022 · 5 comments · Fixed by #558 or #559
Assignees
Labels
hacktoberfest For partifipating in Hacktoberfest noty-android
Milestone

Comments

@Varsha-Kulkarni
Copy link
Contributor

Replace the usages of

setHasOptionsMenu(Boolean): Unit
onCreateOptionsMenu(Menu, MenuInflater): Unit
onOptionsItemSelected(MenuItem): Boolean
onPrepareOptionsMenu(Menu): Unit

with MenuProvider

@PatilShreyas
Copy link
Owner

Assigning it to you

@PatilShreyas
Copy link
Owner

PatilShreyas commented Oct 7, 2022 via email

@PatilShreyas PatilShreyas added hacktoberfest For partifipating in Hacktoberfest noty-android labels Oct 7, 2022
@Varsha-Kulkarni
Copy link
Contributor Author

Sure Shreyas, once I am done with this Options menu issue we will definitely go for more feature additions. It's a privilege that you are asking me this:)

@Varsha-Kulkarni
Copy link
Contributor Author

Hi Shreyas,

I have worked on the same pin_notes branch so that all Options Menu related code gets modified. Is that okay?

@PatilShreyas
Copy link
Owner

Yeah, works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For partifipating in Hacktoberfest noty-android
Projects
Status: Done
2 participants