[ComposeApp] Fix navigation issues #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatilShreyas
commented
Nov 1, 2021
Comment on lines
+184
to
+191
| LaunchedEffect(viewState?.isSuccess) { | ||
| if (viewState?.isSuccess == true) { | ||
| navController.navigate(Screen.Notes.route) { | ||
| launchSingleTop = true | ||
| popUpTo(NOTY_NAV_HOST_ROUTE) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Calling navigation methods directly from a @Composable function is not good and should be strictly avoided. It should be part of a callback. Using LaunchedEffect helps in achieving the same and finally, it fixes the navigation issues 😎
This was
linked to
issues
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix internal app navigation issues in Jetpack Compose app module
Description for the changelog
Checklist