Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<!-- #4

Closed
Patish11 opened this issue Sep 2, 2023 · 1 comment
Closed

<!-- #4

Patish11 opened this issue Sep 2, 2023 · 1 comment
Assignees
@Patish11
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@Patish11
Copy link
Owner

Patish11 commented Sep 2, 2023

Closes #17283

Description

Switches our our method for preventing input into the commit summary, description, and co-authors field while committing to using the readonly attribute rather than disabled. From MDN:

The difference between disabled and readonly is that read-only controls can still function and are still focusable, whereas disabled controls can not receive focus and are not submitted with the form and generally do not function as controls until they are enabled.

I ran this past our a11y folks and they had no objections to this approach.

Release notes

Notes: [Improved] Commit text inputs retain focus while committing

Originally posted by @niik in desktop/desktop#17307
@Patish11 Patish11 self-assigned this Sep 20, 2023
@Patish11 Patish11 added enhancement New feature or request wontfix This will not be worked on labels Sep 20, 2023
@Patish11
Copy link
Owner Author

Closes #17283

Description

Switches our our method for preventing input into the commit summary, description, and co-authors field while committing to using the readonly attribute rather than disabled. From MDN:

The difference between disabled and readonly is that read-only controls can still function and are still focusable, whereas disabled controls can not receive focus and are not submitted with the form and generally do not function as controls until they are enabled.

I ran this past our a11y folks and they had no objections to this approach.

Release notes

Notes: [Improved] Commit text inputs retain focus while committing

Originally posted by @niik in desktop/desktop#17307

This was referenced Sep 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patish11 Patish11

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Patish11