Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain commit summary/description focus while committing #17307

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Conversation

niik
Copy link
Member

@niik niik commented Aug 30, 2023

Closes #17283

Description

Switches our our method for preventing input into the commit summary, description, and co-authors field while committing to using the readonly attribute rather than disabled. From MDN:

The difference between disabled and readonly is that read-only controls can still function and are still focusable, whereas disabled controls can not receive focus and are not submitted with the form and generally do not function as controls until they are enabled.

I ran this past our a11y folks and they had no objections to this approach.

Release notes

Notes: [Improved] Commit text inputs retain focus while committing

Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected!! I did some other testing looking for regressions but couldn't find any 🤞

@niik niik merged commit 2e2c010 into development Aug 31, 2023
7 checks passed
@niik niik deleted the retain-focus branch August 31, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Summary" field loses focus when switching back to the application
2 participants