Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue70 .dockerignore #71

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Issue70 .dockerignore #71

merged 3 commits into from
Mar 24, 2022

Conversation

FelixJacobsen
Copy link
Contributor

Fix #70

Copy link
Contributor

@helenahalldiniths helenahalldiniths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that there were some discutions about first ignoring an entire folder and then "not ignoring" some. Is this the right way to do it?

In the storm project the following is ignored:
target/
.github/
.idea/

@FelixJacobsen
Copy link
Contributor Author

FelixJacobsen commented Mar 21, 2022

Yes I believe it is. target, we don't need anything from from those folders you mentioned. README.md and gitignore is also not a part of the docker build.
These rows will ignore our tests since they should be executed before we make a docker image.
image

How about replacing this with src/test/ ?

@FelixJacobsen
Copy link
Contributor Author

It was Martin who made that solution with the src folder. I was draft this for now so I can make sure it works without any problems.

@FelixJacobsen FelixJacobsen marked this pull request as draft March 21, 2022 17:40
@FelixJacobsen FelixJacobsen marked this pull request as ready for review March 24, 2022 10:51
@FelixJacobsen
Copy link
Contributor Author

Removed target folder to be ignored. We can add thiis once again if we create a multistage dockerfile build.

Copy link
Contributor

@helenahalldiniths helenahalldiniths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@helenahalldiniths helenahalldiniths merged commit a037b55 into main Mar 24, 2022
@helenahalldiniths helenahalldiniths deleted the issue70-.dockerignore branch March 24, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerignore file
2 participants