-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue70 .dockerignore #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that there were some discutions about first ignoring an entire folder and then "not ignoring" some. Is this the right way to do it?
In the storm project the following is ignored:
target/
.github/
.idea/
It was Martin who made that solution with the src folder. I was draft this for now so I can make sure it works without any problems. |
Removed target folder to be ignored. We can add thiis once again if we create a multistage dockerfile build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Fix #70