nion fetches on contruction of a component, which causes requets to h…

…appen during SSR
Patreon · Feb 23, 2019 · 5d58f56 · 5d58f56
1 parent 250894f
commit 5d58f56
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 46 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/decorator/index.js b/src/decorator/index.js
@@ -371,7 +371,7 @@ const nion = (declarations = {}, ...rest) => WrappedComponent => {
             this.initializeDataKeys(nextProps)
         }
 
-        initializeDataKeys(props) {
+        fetchOnMount(props) {
             const { nion } = props // eslint-disable-line no-shadow
 
             // We want to trigger a fetch when the props change and lead to the creation of a new
@@ -411,8 +411,8 @@ const nion = (declarations = {}, ...rest) => WrappedComponent => {
             })
         }
 
-        componentDidMount() {
-            const { nion } = this.props // eslint-disable-line no-shadow
+        initializeDataKeys(props) {
+            const { nion } = props // eslint-disable-line no-shadow
 
             // Iterate over the declarations provided to the component, deciding how to manage the
             // load state of each one
@@ -435,6 +435,10 @@ const nion = (declarations = {}, ...rest) => WrappedComponent => {
             })
         }
 
+        componentDidMount() {
+            this.fetchOnMount(this.props)
+        }
+
         render() {
             // Filter out internally used props to not expose them in the wrapped component
             const nextProps = {

diff --git a/test/integration.test.js b/test/integration.test.js
@@ -170,10 +170,6 @@ describe('nion : integration tests', () => {
                     .find('Container')
                     .props().nion.test
 
-            let test = getProp()
-            expect(test.request.status).toEqual('pending')
-            expect(test.request.isLoading).toEqual(true)
-
             await P.delay(15) // Wait 15ms for the request reducer to update
 
             test = getProp()