Add python six module for python compatibility #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,12 @@ | |||
| import requests | |||
| import six | |||
|
|
|||
| from patreon.jsonapi.parser import JSONAPIParser | |||
| from patreon.jsonapi.url_util import build_url | |||
| from patreon.schemas import campaign | |||
| from patreon.utils import user_agent_string | |||
| from patreon.version_compatibility.utc_timezone import utc_timezone | |||
There was a problem hiding this comment.
Can you get this from six.moves as well? Maybe version_compatibility can go away.
There was a problem hiding this comment.
I unfortunately didn't find any six documentation for timezone compatibility
|
I don't see a change to requirements.txt here. You'll want to update it with |
jrsun
approved these changes
May 15, 2018
patreon/api.py
Outdated
| raise Exception( | ||
| 'Provided cursor path did not result in a link', current_dict | ||
| ) | ||
| if type(current_dict) != six.text_type: |
There was a problem hiding this comment.
let's just replace type(current_dict) != str on line 73 with this check.
lynneatan
added a commit
that referenced
this pull request
May 16, 2018
This reverts commit 00fc7b8.
lynneatan
added a commit
that referenced
this pull request
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #19 Error in extract_cursor() method (#19)
Problem:
Solution: