Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rails from 6.1 to 7.1 #162

Merged
merged 1 commit into from
Nov 15, 2023
Merged

upgrade rails from 6.1 to 7.1 #162

merged 1 commit into from
Nov 15, 2023

Conversation

JFen9
Copy link
Collaborator

@JFen9 JFen9 commented Nov 15, 2023

upgrade rails to latest, along with some other gems.

tested in staging

@JFen9 JFen9 requested a review from PatrickF1 November 15, 2023 22:04
@@ -24,7 +24,7 @@
config.public_file_server.enabled = ENV['RAILS_SERVE_STATIC_FILES'].present?

# Compress JavaScripts and CSS.
config.assets.js_compressor = :uglifier
config.assets.js_compressor = :terser
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encountered lautis/uglifier#185

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so it was because our JS is ES6? Haha can't believe the FE was so advanced.

Copy link
Owner

@PatrickF1 PatrickF1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joseph! I upgraded staging to Heroku-22 stack, redeployed, and it works.

@PatrickF1 PatrickF1 merged commit 2cbf5af into master Nov 15, 2023
1 check passed
@PatrickF1 PatrickF1 deleted the rails-upgrade branch November 15, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants