Make instructions to open file in editor clearer #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jjant, thanks for opening up this PR! The readme is more for documentation and the cookbook is more for implementing customizations. Do you mind if I copy your example/code into the Cookbook instead? |
|
Ah I did have it in the Wiki but in the Troubleshooting instead of Cookbook, where it fits better. My bad! |
PatrickF1
reviewed
Oct 24, 2022
| # set -gx $EDITOR "nvim" # or "vim", or "code", etc. | ||
|
|
||
| # Ctrl-o will open the selected file/directory in your editor of choice. | ||
| set fzf_dir_opts --bind "ctrl-o:execute($EDITOR {} &> /dev/tty)" |
There was a problem hiding this comment.
in case anyone is referencing this in the future, fzf_dir_opts has been renamed to fzf_directory_opts.
|
@PatrickF1 Thanks for taking a look at the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It took me a while to understand how to actually set up a binding to open the selected file from the linked issue in the readme, so I thought it'd be clearer to show an example with the actual code that will do it.