Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when passing string bins to histogram #96

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

verdimrc
Copy link
Contributor

Fix crash when passing string bins to histogram, to be consistent with the documentation: "If bins is a string, it defines the method used to calculate the optimal bin width, as defined by histogram_bin_edges.".

@PatrikHlobil
Copy link
Owner

Hi @verdimrc ,

thanks for submitting this fix. I had a look at the MR and it looks fine for me. The tests did not pass, but this seems to be an issue with an old dependency in the pipeline, which I am currently fixing. I would directly merge the branch if this fits for you?

Best Patrik

@verdimrc
Copy link
Contributor Author

hi @PatrikHlobil , thank you for taking a look, and appreciate for merging.

Regards,
Verdi

@PatrikHlobil PatrikHlobil merged commit 9bc0569 into PatrikHlobil:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants