Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pattern: datetimepicker, Masonry enhancements #520

Merged
merged 6 commits into from May 16, 2018
Merged

New pattern: datetimepicker, Masonry enhancements #520

merged 6 commits into from May 16, 2018

Conversation

thet
Copy link
Member

@thet thet commented Sep 15, 2017 •
edited

This targets the 2.1.x branch. A forward port to master is at: #575

pat-masonry

  • Re-Layout on load events emitted on img nodes within the masonry scope.
  • Do not depend on imagesloaded.
  • Update masonry to version 4.2.0.
  • Align options with new version:
    • Add options is-horizontal-order, is-percent-position and is-resize.
    • Remove options visible-style and hidden-style.
    • Add Aliases from v4 (no is-*) to v3 names (with is- for booleans), while keeping the v3 names. The patternslib parser does boolean casting for is-* options.

pat-datetime-picker

  • Add new pattern for setting the date and time.

pat-date-picker

  • Remove the dependency on moment-timezone-data - it's not used and there is no use in a date picker anyways.

Makefile

  • with the clean target, also remove the stamp-bundler marker file.

@thet thet changed the base branch from master to 2.1.x September 15, 2017 14:06
This was referenced Sep 15, 2017
Closed
Closed
Closed
@pilz pilz closed this Dec 4, 2017
@thet
Copy link
Member Author

thet commented Dec 4, 2017

why closed?

@pilz
Copy link
Member

pilz commented Dec 4, 2017

oops, I didn't consciously close this… Probably I mis-picked in waffle.

@pilz
Copy link
Member

pilz commented Dec 4, 2017

Dammit, why can't I reopen this?

@thet
Copy link
Member Author

thet commented Dec 4, 2017

ok :)
these changes can probably soon be merged. just have to review myself

@pilz
Copy link
Member

pilz commented Dec 4, 2017

Can you see what happened here? What did I do to not being able to reopen this?

@thet
Copy link
Member Author

thet commented Dec 4, 2017

hm. did you delete the 2.1.x branch too? it's targeted to 2.1.x branch, my "reopen" button says it's gone.

@pilz
Copy link
Member

pilz commented Dec 4, 2017

aaaah, dammit, I that was it. I thought that was a stale branch that I don't need anymore.

@thet
Copy link
Member Author

thet commented Dec 4, 2017

maybe i created it to have a 2.1.x release branch.
i recreate it, ok?

@pilz
Copy link
Member

pilz commented Dec 4, 2017

A warning would have been nice. Any suggestion how to save the day?

@pilz
Copy link
Member

pilz commented Dec 4, 2017

yes, please!

@thet thet reopened this Dec 4, 2017
@thet
Copy link
Member Author

thet commented Dec 4, 2017

done.
i promise, i'll finish this PR so that it can be merged soon!

@pilz
Copy link
Member

pilz commented Dec 4, 2017

Aaah, super. And I promise to keep my fingers away until after xmas…

@pilz
Copy link
Member

pilz commented Dec 4, 2017

Sorry ;)

@thet
Copy link
Member Author

thet commented Dec 4, 2017

no problem :)

@thet
pat-masonry optimizations
9760047 
- Re-Layout on ``load`` events emitted on ``img`` nodes within the masonry scope.
- Do not depend on ``imagesloaded``.
- Update masonry to version 4.2.0.
- Align options with new version:
  - Add options ``is-horizontal-order``, ``is-percent-position`` and ``is-resize``.
  - Remove options ``visible-style`` and ``hidden-style``.
  - Add Aliases from v4 (no ``is-*``) to v3 names (with ``is-`` for booleans), while keeping the v3 names. The patternslib parser does boolean casting for ``is-*`` options.
@thet thet requested a review from pilz January 26, 2018 08:35
@thet
Copy link
Member Author

thet commented Jan 26, 2018

Ready to review!

I'll prepare a PR for master.
The tests for date-picker don't run (they were also not included before...) but I wrote tests for the new datetime-picker.

Despite of the initial scope of only adding a datetime picker, I extended this PR to also include updates to pat-masonry.

@thet thet removed the in progress label Jan 26, 2018
@thet thet changed the title WIP: New pattern: datetimepicker New pattern: datetimepicker, Masonry enhancements Jan 26, 2018
@thet thet mentioned this pull request Jan 26, 2018
Merged
@pilz
Copy link
Member

pilz commented Feb 8, 2018

I am still recovering from a heavy flu. I have this on my list, need a bit more time.

@thet
Copy link
Member Author

thet commented Apr 26, 2018

@pilz @ale-rt ping

@jensens
Copy link
Member

jensens commented May 16, 2018

LGTM, when can we expect a merge?

@pilz pilz merged commit 94f10ed into 2.1.x May 16, 2018
@pilz
Copy link
Member

pilz commented May 16, 2018

Sorry for the delay!

@pilz pilz deleted the thet-datepicker branch May 16, 2018 13:45
@jensens
Copy link
Member

jensens commented May 16, 2018

Thanks!

@jensens
Copy link
Member

jensens commented May 16, 2018

@thet oh, this is on the branch, so master would need this too?

@thet
Copy link
Member Author

thet commented May 16, 2018

@jensens yes, but there are some test failures to resolve: #575

master is webpack based. Plone uses currently the non-webpack 2.1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilz pilz Awaiting requested review from pilz

Assignees
No one assigned
Labels
New feature New Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thet @pilz @jensens