Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there is a non-zero exit code when the programme errors #9

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

Johnabell
Copy link
Contributor

Currently if cargo liner fails in CI it can fail silently since its exit code on success or failure is zero. This PR updates the behaviour to have a non-zero exit code on failure.

@PaulDance PaulDance self-requested a review January 4, 2024 18:37
Copy link
Owner

@PaulDance PaulDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for this! I was indeed already aware of it, but didn't take the time to fix it.

Consider the second comment and we should be good to go!

Cheers,
Paul.

src/config/user_config.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
Copy link
Owner

@PaulDance PaulDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks a bunch!

@PaulDance PaulDance merged commit b19f0a4 into PaulDance:master Jan 4, 2024
1 check passed
@PaulDance
Copy link
Owner

Released as part of v0.4.2.

@PaulDance PaulDance added this to the v0.4.2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants