Require base >= 4.11. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails to build with base <= 10 / ghc 8.2 due to the missing Semigroup
class:
Data/Ranged/RangedSet.hs:74:31: error:
Not in scope: type constructor or class ‘Semigroup’
|
74 | instance DiscreteOrdered a => Semigroup (RSet a) where
| ^^^^^^^^^
|
OK, I've accepted the pull request and updated the metadata in Hackage. Let me know if that works and I'll close the report. |
|
Thanks! It seems though that you revised the test build-depends instead of the library build-depends: http://hackage.haskell.org/package/Ranged-sets-0.4.0/revisions/, would you mind also updating the library? (Build failure here building postgrest with ghc 8.0 because it tries to use Ranged-sets-0.4.0: https://travis-ci.org/robx/postgrest/jobs/542330852) |
|
That was quick thank you! The build works now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ranged-sets-0.4.0 fails to build with base <= 10 / ghc 8.2 due to the missing Semigroup
class.
This is causing me build failures trying to build postgrest with older ghc versions.
Could you please also apply this change via hackage's "edit package information" to
ensure that cabal chooses Ranged-sets <0.4 when building with older ghc versions?
If you like, I'd be happy to test and submit a PR for a Ranged-sets-0.4.1 that builds
with older base versions.