Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MultiPolygon 'polygons' prop to allow polygons with holes #218

Merged
merged 1 commit into from Sep 8, 2016
Merged

Updated MultiPolygon 'polygons' prop to allow polygons with holes #218

merged 1 commit into from Sep 8, 2016

Conversation

ernoaapa
Copy link
Contributor

@ernoaapa ernoaapa commented Sep 8, 2016

Like 'Polygon' already allows passing array of arrays to make holes, also
MultiPolygon should allow it. Even though not read in Leaflet
MultiPolygon documentation, it supports it because Polygon supports it.

Like 'Polygon' already allows passing array of arrays to make holes, also
MultiPolygon should allow it. Even though not read in Leaflet
MultiPolygon documentation, it supports it because Polygon support it.
@PaulLeCam
Copy link
Owner

Hi,
Thanks for this PR, do you have a reference of this support by Leaflet please?

@ernoaapa
Copy link
Contributor Author

ernoaapa commented Sep 8, 2016

Oh yeah sure! In Leaflet Polygon documentation http://leafletjs.com/reference.html#polygon it says:
"You can also create a polygon with holes by passing an array of arrays of latlngs, with the first latlngs array representing the exterior ring while the remaining represent the holes inside."

@PaulLeCam
Copy link
Owner

Thanks!

@PaulLeCam PaulLeCam merged commit a576af6 into PaulLeCam:master Sep 8, 2016
@PaulLeCam
Copy link
Owner

Released in v0.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants