Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Implement privatevocal cog #17

Closed
PaulMarisOUMary opened this issue Mar 6, 2022 · 1 comment · Fixed by #36
Closed

Re-Implement privatevocal cog #17

PaulMarisOUMary opened this issue Mar 6, 2022 · 1 comment · Fixed by #36
Labels
feature request A feature request
Projects
Algobot

Comments

@PaulMarisOUMary
Copy link
Owner

Is your feature request related to a problem? Please describe.

The privatevocal cog was a cool feature released in the v1.0. However due to the way it was made, it was very expensive in term of resources, the workload increased over time making the other bot's commands unusable (or with a really hight timeout) which was a big issue. So this cog was deleted on the next release.
I'd like to re-introduce this useful feature with the solution bellow.

Describe the solution you'd like

Replacing the loop_if_connected task with the on_voice_state_update event listener (doc here), with this structure the cog should be way much lighter.
https://github.com/PaulMarisOUMary/Algosup-Discord/blob/1f661b212cc6938f2cc687fa83847ad626fbcc5e/cogs/privatevocal.py#L21-L68

Additional context

Processor usage Before/After disabling the privatevocal cog (released with the v1.0).
Screenshot 2021-09-27 at 09 44 32
(Bot hosted on the cheapest virtual machine on GoogleCloudPlatform.)
@PaulMarisOUMary PaulMarisOUMary added this to To do in Algobot Mar 6, 2022
PaulMarisOUMary added a commit that referenced this issue Mar 27, 2022
@PaulMarisOUMary
in dev still in progress, add private vocal cog #17
54c8e1e
@leo-chartier leo-chartier mentioned this issue Mar 28, 2022
Closed
6 tasks
PaulMarisOUMary added a commit that referenced this issue Mar 30, 2022
@PaulMarisOUMary
Reimplement #17
8569f4b 
Due to ratelimits restrictions we can't implement the old #17 privatevocal cog.

*Bonus: Add reload_config in cogs.admin
*Fix cogs.croissants cooldown
@PaulMarisOUMary
Copy link
Owner Author

Due to ratelimits the #34 was closed.

@PaulMarisOUMary PaulMarisOUMary linked a pull request Mar 30, 2022 that will close this issue
Reimplement #17 #36
Merged
6 tasks
@PaulMarisOUMary PaulMarisOUMary mentioned this issue Mar 30, 2022
Merged
6 tasks
Algobot automation moved this from To do to Done Mar 30, 2022
PaulMarisOUMary added a commit that referenced this issue Mar 30, 2022
@PaulMarisOUMary
Merge pull request #36 from PaulMarisOUMary/reimplement-privatevocal
3dfaed3 
Reimplement #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request A feature request
Projects
No open projects
Algobot
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplement #17 PaulMarisOUMary/Discord-Bot
1 participant
@PaulMarisOUMary