Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dad joke cog #22

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Dad joke cog #22

merged 5 commits into from
Mar 8, 2022

Conversation

leo-chartier
Copy link
Contributor

Summary

This pull request adds a cog that will autoreply on messages with dad jokes.
Currently only Hi X I'm Y is implemented.
Because it can very easily be annoying, a probability of occurrence has been added.

Example:

image

Checklist

  • If code changes were made then they have been tested.1
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters or reference to an issue).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)1
  • This PR is not a code change (e.g. documentation, README, ...)

Footnotes

  1. This feature has been tested on another bot. Only adaptation changes were made meaning the bot should work. 2

@PaulMarisOUMary PaulMarisOUMary added the feature request A feature request label Mar 8, 2022
@PaulMarisOUMary PaulMarisOUMary added this to Waiting for approval in Algobot Mar 8, 2022
Copy link
Owner

@PaulMarisOUMary PaulMarisOUMary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the following:

  • Setup the dad config in the /config/bot.json
  • Then change the line 10 of your /cogs/dad.py with self.settings = bot.bot_data["dad"]

Copy link
Owner

@PaulMarisOUMary PaulMarisOUMary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature 👍

@PaulMarisOUMary PaulMarisOUMary moved this from Waiting for approval to Done in Algobot Mar 8, 2022
@PaulMarisOUMary PaulMarisOUMary merged commit fe273a9 into PaulMarisOUMary:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants