Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aiomysql-runtimeerror & add cogs.metrics #57

Merged
merged 7 commits into from
May 14, 2022
Merged

Fix Aiomysql-runtimeerror & add cogs.metrics #57

merged 7 commits into from
May 14, 2022

Conversation

PaulMarisOUMary
Copy link
Owner

@PaulMarisOUMary PaulMarisOUMary commented May 14, 2022 •
edited
Loading

Summary

Fix #56

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue:
  • This PR adds something new:
    • New cogs.metrics
    • SQL performance improvement
    • Allows multiple connections at the same time using DataSQL
    • Remove views.fridaycake & cogs.fridaycake
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@PaulMarisOUMary
add test file & cogs.metrics
08da224
@PaulMarisOUMary
add metrics in database.json
97f422e
@PaulMarisOUMary
starting to fix #56 (pool) & starting to implement metrics
ad930ea
@PaulMarisOUMary
remove unused condition insinde on_command listener
975d7e6
@PaulMarisOUMary
starting to refactor database.py
883e566 
- new `insert_onduplicate` method
- new private methods for convenience
@PaulMarisOUMary
refactor increment method
aba21ba
@PaulMarisOUMary
implement metrics & fix diverse bugs
ca23372 
- Fix SQL varchar
- Fix Database Acknowledgement in README
- Improve performances with different types of SQL Query in few cogs
- Rename to subconfig_data few variables with an access to bot.config
@PaulMarisOUMary PaulMarisOUMary linked an issue May 14, 2022 that may be closed by this pull request
aiomysql: RuntimeError #56
Closed
@PaulMarisOUMary PaulMarisOUMary merged commit b7ba67a into main May 14, 2022
@PaulMarisOUMary PaulMarisOUMary deleted the aiomysql-runtimeerror branch May 16, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aiomysql: RuntimeError
1 participant
@PaulMarisOUMary